Opened 11 years ago

Last modified 5 years ago

#149 assigned enhancement

addLogObserver and progressMetrics

Reported by: sergey Owned by:
Priority: minor Milestone: 2.0.+
Version: 0.7.6 Keywords:
Cc: toinbis

Description

Brian Warner wrote:

On Sat, 24 Nov 2007 13:06:32 -0500 "Sergey A. Lipnevich" wrote:

In 0.7.6, adding log observer that produces new metrics is tricky because each new metric must be also mentioned in build step's progressMetrics member. Would it be better instead to declare all metrics provided by log observer in its class, and automatically add new metrics names to progressMetrics once the observer instance is added? I can file a ticket and submit a patch, I'm asking here first if it's a good idea to make this change.

I think that's a good idea. You'll need to double-check that the "expectations" are still filled in correctly.. it's been a long time since I looked at that code, but I seem to remember there is a place where we run through all steps and fill them with expectations from the previous build. We'd need to make sure that we enumerate the metrics before doing this setting-expectations phase.

Change History (8)

comment:1 Changed 10 years ago by warner

this still sounds like a good idea :)

comment:2 Changed 10 years ago by clepple

If nothing else, we might need a patch to the documentation to mention that you need to add the metric name to progressMetrics.

Is there a reason why progressMetrics is a tuple (rather than a list)? I was trying to append to it since I didn't know the names of the internal metrics (only 'output', it seems).

comment:3 Changed 9 years ago by dustin

  • Milestone changed from undecided to 0.7.+

calling all patcheS!

comment:4 Changed 8 years ago by dustin

  • Cc toinbis added
  • Milestone changed from 0.8.+ to 0.8.1
  • Owner changed from sergey to toinbis
  • Status changed from new to assigned

comment:5 Changed 8 years ago by dustin

  • Milestone changed from 0.8.2 to 0.8.3

toinbis - did you ever get around to working on this?

comment:6 Changed 8 years ago by dustin

  • Milestone changed from 0.8.3 to 1.0.+

comment:7 Changed 6 years ago by tom.prince

  • Owner toinbis deleted

comment:8 Changed 5 years ago by tom.prince

  • Priority changed from patches-accepted to minor
Note: See TracTickets for help on using tickets.