Ticket #145 (closed enhancement: fixed)

Opened 6 years ago

Last modified 4 years ago

Patch: split OneLineMixin.make_line

Reported by: amax_snaplogic Owned by:
Priority: major Milestone: 0.7.10
Version: 0.7.6 Keywords:
Cc:

Description

Hi,

This patch refactors OneLineMixin?.make_line(), splitting in into two methods: one that gathers all the data needed for a build (get_line_values), and one that takes that data, and renders it into an HTML line (make_line).

The win here is that someone can customize the HTML display of a report more easily by subclassing OneLineMixin? (or more likely, one of its subclasses) and overridding make_line(). One could before, of course, but now they can reuse the data-gathering code by calling get_line_values().

Attachments

OneLineMixin.make_line.patch Download (1.1 KB) - added by amax_snaplogic 6 years ago.
Patch to split OneLineMixin?.make_line

Change History

Changed 6 years ago by amax_snaplogic

Patch to split OneLineMixin?.make_line

comment:1 Changed 5 years ago by warner

  • Milestone changed from undecided to 0.7.8

cool.

comment:2 Changed 4 years ago by dustin

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from 0.8.0 to 0.7.10 
commit 1f3b1dcb7b0572151bfc03bb2e7856003913046d
Author: dustin <dustin@v.igoro.us>
Date:   Fri Apr 4 08:25:51 2008 +0100

    #145:OneLineMixin.make_line.patch
    
    Patch from Aaron Maxwell <amax@snaplogic.org>.  Refactor
    OneLineMixin.make_line(), splitting in into two methods: one that
    gathers all the data needed for a build (get_line_values), and one
    that takes that data, and renders it into an HTML line (make_line).
Note: See TracTickets for help on using tickets.