Ticket #144 (closed defect: fixed)

Opened 4 years ago

Last modified 4 years ago

Missing 'builders' part in URL reported by IRC bot

Reported by: mloskot Owned by:
Priority: major Milestone: 0.7.7
Version: 0.7.6 Keywords: irc bot url
Cc:

Description

URL reported by IRC bot on finished build is incomplete and builders part is missing:

[01:55]  <mloskot> force build telascience-quick
[01:55]  <bbqgis> Build forced [ETA 56 seconds]
[01:55]  <bbqgis> I'll give a shout when the build finishes
[01:55]  <bbqgis> Hey! Build telascience-quick 5 is complete: Success [build successful]
[01:55]  <bbqgis> Build details are at http://buildbot.osgeo.org:8505/telascience-quick/builds/5

This is incorrect address:

http://buildbot.osgeo.org:8505/telascience-quick/builds/5

and should read:

http://buildbot.osgeo.org:8505/builders/telascience-quick/builds/5

As I see this URL is generated by

def getURLForThing(self, thing):

in status/builder.py, lines 1805, 18013, etc. and it should be enough to add builders part to the format string :

return "%s/builders/%s/builds/%d" % (
   prefix,
   urllib.quote(builder.getName(), safe=''),
   build.getNumber())

but I'm not sure if my investigation is correct.

Change History

comment:1 Changed 4 years ago by semi

  • Status changed from new to closed
  • Resolution set to fixed
  • Milestone changed from undecided to 0.7.7

This seems to be fixed already in buildbot CVS.

Note: See TracTickets for help on using tickets.