Ticket #137 (closed defect: fixed)
Time zone name wrong in waterfall header (says I'm in DST when I'm not)
|Reported by:||spiff||Owned by:|
|Version:||0.7.6||Keywords:||daylight savings time DST waterfall|
Here in November in the US Pacific Time zone, we're currently observing standard time (PST). However, the header of the waterfall display says it's PDT.
In status/web/waterfall.py, function "body", around line 503:
TZ = time.tzname[time.daylight]
TZ = time.tzname[time.localtime()[-1]]
It turns out that time.daylight only tells you if the region you're in observes DST at some time of the year; if you want to know whether or not DST is *currently in effect*, you need the last item of the localtime time tuple.
Twisted's log.py also makes this mistake, causing log.msg to report the time wrong in the twistd.log(s).
A similar fix is probably needed in tests/tests_web.py, line 235 (Class Waterfall, def _check1)