![[Buildbot Logo]](/chrome/site/header-text-transparent.png)
Ticket #129 (closed defect: fixed)
buildbot slaves crash on large log output
| Reported by: | chops@… | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 0.7.7 |
| Version: | 0.7.5 | Keywords: | |
| Cc: |
Description
buildbot currently stuffs the entirety of the log output it reads from its child process's stdio into twisted, which causes twisted to fail if the output is longer than 640k. This seems to be a limitation that's hard to fix in twisted, so I've added code locally to chunk up the output in buildbot instead. I've not tested this code thoroughly, but it looks like we may be migrating away from buildbot here, so I figured I should send the patch in before it gets lost in the sands of time.
Cheers.
Attachments
-
large-logfile-crash-fix.patch
(1.8 KB) -
added by chops@… 4 years ago.
- Patch which we're using to fix this problem
Change History
Changed 4 years ago by chops@…
-
attachment
large-logfile-crash-fix.patch
added
comment:1 Changed 4 years ago by warner
- Milestone changed from undecided to 0.7.7
ooh, good catch.. I've never had a system that emitted enough stdout fast enough to trigger this limitation. Thanks for the patch.
comment:2 Changed 4 years ago by warner
- Status changed from new to closed
- Resolution set to fixed
Applied, in [b3a1dfb8ada150b28960bbcad89dfdb6eaef1493]. I wasn't able to reproduce the problem locally (my commands just can't write output fast enough, I guess), but the bug is clear, and should now be avoided. Thanks!
Patch which we're using to fix this problem