Ticket #127 (closed defect: fixed)

Opened 6 years ago

Last modified 4 years ago

got_revision not tracked for perforce

Reported by: dsallings Owned by:
Priority: major Milestone: 0.7.10
Version: 0.7.5 Keywords: perforce p4
Cc:

Description

(this is a bug I filed on sf in August 2007 -- didn't realize you guys moved)

I was attempting to include the latest perforce changeset in my build and found that got_revision is never populated.

I couldn't find a way to generically handle this (especially since p4 doesn't actually seem to do much with changesets), but it should work at least in the case where buildbot syncs to a particular revision.

The attached patch (against whatever I just pulled down with darcs) will set got_revision to the requested revision.

Attachments

p4revfix.diff Download (1.1 KB) - added by dsallings 6 years ago.
make got_revision work for perforce builds

Change History

Changed 6 years ago by dsallings

make got_revision work for perforce builds

comment:1 Changed 5 years ago by dsallings

  • component changed from other to vc-support

comment:2 Changed 4 years ago by dustin

  • Status changed from new to closed
  • Resolution set to fixed

solved by a patch by jgraff:  http://github.com/jgraff/buildbot/commit/ab61561c9bc98d69b64db2b3bdb5c05dce969264

comment:3 Changed 4 years ago by dustin

  • Milestone changed from undecided to 0.7.10
Note: See TracTickets for help on using tickets.