Opened 12 years ago

Closed 11 years ago

Last modified 11 years ago

#127 closed defect (fixed)

got_revision not tracked for perforce

Reported by: dsallings Owned by:
Priority: major Milestone: 0.7.10
Version: 0.7.5 Keywords: perforce p4
Cc:

Description

(this is a bug I filed on sf in August 2007 -- didn't realize you guys moved)

I was attempting to include the latest perforce changeset in my build and found that got_revision is never populated.

I couldn't find a way to generically handle this (especially since p4 doesn't actually seem to do much with changesets), but it should work at least in the case where buildbot syncs to a particular revision.

The attached patch (against whatever I just pulled down with darcs) will set got_revision to the requested revision.

Attachments (1)

p4revfix.diff (1.1 KB) - added by dsallings 12 years ago.
make got_revision work for perforce builds

Download all attachments as: .zip

Change History (4)

Changed 12 years ago by dsallings

make got_revision work for perforce builds

comment:1 Changed 12 years ago by dsallings

  • component changed from other to vc-support

comment:2 Changed 11 years ago by dustin

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed 11 years ago by dustin

  • Milestone changed from undecided to 0.7.10
Note: See TracTickets for help on using tickets.