Opened 8 years ago

Last modified 4 years ago

#1064 new enhancement

Logging ChangeFilter checks

Reported by: strk Owned by:
Priority: major Milestone: 0.9.+
Version: 0.8.2 Keywords: sprint, logging
Cc: dwlocks

Description (last modified by dustin)

While trying to understand Scheduler and ChangeFilter? activity I've noticed there's no much logged about its activity, making it hard to understand why a signaled change doesn't trigger any build.

I was suggested by djmitche on #buildbot freenode to file a ticket for this.

Change History (9)

comment:1 Changed 8 years ago by dustin

  • Milestone changed from undecided to 0.8.3
  • Type changed from undecided to enhancement

comment:2 Changed 8 years ago by dustin

  • Milestone changed from 0.8.3 to 0.8.+

comment:3 Changed 7 years ago by dustin

  • Keywords sprint added

comment:4 Changed 6 years ago by tom.prince

  • Milestone changed from 0.8.+ to 0.8.8

comment:5 Changed 6 years ago by tom.prince

  • Milestone changed from 0.8.8 to 0.8.+

comment:6 Changed 6 years ago by dustin

  • Cc dwlocks added
  • Keywords logging added

Dan, another bug related to our conversation today about verbose logging

comment:7 Changed 5 years ago by dcoshea

If I create a ChangeFilter with only filter_fn set, then all that the proposed logging code sitting outside of my function could indicate was what the content of the Change object was and whether my function returned True or False. I've put a few "print" statements in my filter function so I can work out why it is returning True or False. When this verbose logging is added, would it make sense to make the logging object available to the filter_fn so my logging could be tied in with the standard logging?

comment:8 Changed 5 years ago by dustin

  • Description modified (diff)

The logging objet is a module (twisted.python.log), so there's no need to pass it anywhere. For debugging purposes, print does the same thing (and is easy to grep for later when you're removing the debugging).

comment:9 Changed 4 years ago by dustin

  • Milestone changed from 0.8.+ to 0.9.+

Ticket retargeted after milestone closed

Note: See TracTickets for help on using tickets.