Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#1060 closed enhancement (fixed)

Standardize URL arguments to form templates

Reported by: ayust Owned by:
Priority: major Milestone: 0.8.3
Version: master Keywords: web
Cc:

Description

Right now, we pass URLs to our various template forms (force build, etc) without any real pattern - they just get echo'd out into the page as we pass them, and we hope that they point to the right thing.

We should realize standardize these URLs so that either...

a) They're all relative to the buildbot root (so that we can pass "builders/_all/forceall" from any page, even if it's a subdirectory)

or

b) There's a flag to force the path relative to root (so that if the flag is enabled, we can pass a relative-to-root path from any page, regardless of subdirectories).

Change History (4)

comment:1 Changed 8 years ago by dustin

  • Keywords web added
  • Milestone changed from undecided to 0.8.3
  • Type changed from undecided to enhancement

comment:2 Changed 8 years ago by dustin

We're using the path_to_root variable now, which seems functional. What would you suggest to improve that?

comment:3 Changed 8 years ago by dustin

  • Resolution set to fixed
  • Status changed from new to closed

Maybe I misunderstand, but I think we already do this. Re-open to convince me :)

comment:4 Changed 7 years ago by aivarsk

Not sure if ayust meant the same, but buildstatus bubble as used in /console view will always have URL like: builders/hpux11.00%2032-hppa2.0w%20gcc4.2%20ora9.2%20tux8.1/builds/2174

I have created /projects view and per-project /projects/project_name view. If I use buildstatus bubble in /projects/project_name view it will actually point to non-existing URL /projects/builders/hpux11.00%2032-hppa2.0w%20gcc4.2%20ora9.2%20tux8.1/builds/2174

Last edited 7 years ago by aivarsk (previous) (diff)
Note: See TracTickets for help on using tickets.