Opened 4 years ago

Closed 4 years ago

#1043 closed defect (fixed)

Skipped step status is merged incorrectly into overall build

Reported by: Dylan Owned by:
Priority: major Milestone: 0.8.3
Version: 0.8.2 Keywords:
Cc:

Description (last modified by dustin)

Say I have builder b1 which triggers builder b2 and waits for it to finish.

b2 has a step which is skipped. This causes b1 to fail when it should succeed.

Another symptom of this problem is that builds that should be green on the top of the waterfall are white because they obviously have an overall status of skipped.

A quick fix that worked for me is as follows. I'm sure this will make it obvious to someone else what needs to be fixed.

In buildbot/process/base.py inside the stepDone method I added this conditional (and imported SKIPPED)

if result != SKIPPED:
    self.result = worst_status(self.result, possible_overall_result)

Thanks

Change History (2)

comment:1 Changed 4 years ago by dustin

  • Description modified (diff)
  • Milestone changed from undecided to 0.8.3

comment:2 Changed 4 years ago by Dustin J. Mitchell

  • Resolution set to fixed
  • Status changed from new to closed

Do not propagate SKIPPED status from step to build

Fixes #1043

Changeset: 3c1da86968a623a0fd17183461da8afe213bb2b5

Note: See TracTickets for help on using tickets.