Skipped step status is merged incorrectly into overall build
|Reported by:||Dylan||Owned by:|
Description (last modified by dustin)
Say I have builder b1 which triggers builder b2 and waits for it to finish.
b2 has a step which is skipped. This causes b1 to fail when it should succeed.
Another symptom of this problem is that builds that should be green on the top of the waterfall are white because they obviously have an overall status of skipped.
A quick fix that worked for me is as follows. I'm sure this will make it obvious to someone else what needs to be fixed.
In buildbot/process/base.py inside the stepDone method I added this conditional (and imported SKIPPED)
if result != SKIPPED: self.result = worst_status(self.result, possible_overall_result)