Ticket #104 (closed defect: fixed)

Opened 5 years ago

Last modified 3 years ago

adding branch= to the waterfall is expensive

Reported by: warner Owned by: warner
Priority: critical Milestone: 0.8.+
Version: 0.7.5 Keywords: waterfall, branches
Cc:

Description

I added a max_search= to the IBuilderStatus.generateFinishedBuilds method, to limit how many builds are searched when constructing the one_line_per_build and one_box_per_builder pages, but the eventGenerator() method used by the waterfall has no such limit. As a result, actually using the new branch= argument on the waterfall page is very expensive, as any Builder which has never built that branch will cause eventGenerator() to run through its entire history, pulling each build off disk to check the branch name.

The long-term fix for this is to use a database for status information which can get us this information faster. The short-term fix (after 0.7.6, unfortunately) is to add a similar max_seach= argument to eventGenerator. It's too complex to add today, though.

Change History

comment:1 Changed 4 years ago by warner

  • Milestone changed from 0.7.7 to 0.7.8

No progress made on this yet, bumping to 0.7.8

comment:2 Changed 3 years ago by dustin

  • Status changed from new to closed
  • Resolution set to fixed

Waterfall is going to be removed/replaced.

comment:3 Changed 3 years ago by dustin

  • Milestone changed from 0.8.0 to 0.7.+
Note: See TracTickets for help on using tickets.