![[Buildbot Logo]](/chrome/site/header-text-transparent.png)
Ticket #1000 (closed defect: fixed)
"Force All Builds" misses repo, project information
| Reported by: | moschny | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 0.8.2 |
| Version: | master | Keywords: | |
| Cc: | moschny |
Description
Note, this is related to, but not a duplicate of #999.
Builds induced by the 'Force All Builds' knob on the /builders page don't know about their repository or project fields. Unlike the situation in #999, it might not be feasible to add form fields for that, so the information must be collected elsewhere.
At least for the repository field, it is very likely the Build knows it, because it does the checkout.
So, this is basically a request for enabling Builders to set/add/correct repository and project fields of the SourceStamp (setting properties of the same name does not help).
Change History
comment:1 follow-up: ↓ 2 Changed 3 years ago by dustin
- Type changed from enhancement to defect
- Milestone changed from undecided to 0.8.2
comment:2 in reply to: ↑ 1 Changed 3 years ago by moschny
Replying to dustin:
I don't want to edit the source stamp - information isn't supposed to flow that way.
I agree it is not normally flowing in that direction. The buttons are exceptional though. The proper fix would be to make them a ChangeSource, I guess.
However, "Force All Builds" is really a very blunt hammer for a very blunt purpose, and I don't see why we can't make it more blunt by requiring that it apply the same project and repository to all triggered builds?
No please don't. The way it is now, I can press it to get a build for all my projects (with incomplete SourceStamps, but in my case this affects only web view, as each builder knows from which repo it should build.) This wouldn't work anymore when the same repo/project is forced upon all builders.
comment:3 follow-up: ↓ 4 Changed 3 years ago by dustin
- Summary changed from web-induced builds miss repo, project information to "Force All Builds" misses repo, project information
Well, you could leave the repository field blank, right?
comment:4 in reply to: ↑ 3 Changed 3 years ago by moschny
Replying to dustin:
Well, you could leave the repository field blank, right?
Oh, right, I misunderstood you.
comment:5 Changed 3 years ago by ayust
It really is a blunt hammer... especially if you have builders operating on Triggerable builders from other builders' Triggers... since it will run the former twice (once at the Force, once when the latter builders Force builds hit their Trigger steps)...
This really should just be made a "web status change source" or some such.
I don't want to edit the source stamp - information isn't supposed to flow that way.
I fundamentally dislike the "Force Build" button, because it skips the rest of the Buildbot process for generating builds, and generally causes problems when it falls out of alignment with the usual BuildSet/BuildRequest process. But it's here, and #999 is a simple enough fix, so I'll keep it up to date.
However, "Force All Builds" is really a very blunt hammer for a very blunt purpose, and I don't see why we can't make it more blunt by requiring that it apply the same project and repository to all triggered builds?