Ticket #743: ticket743-full.diff

buildbot/status/web/baseweb.py

@@ -20 +20 @@
 from buildbot.status.web.changes import ChangesResource
 from buildbot.status.web.builder import BuildersResource
 from buildbot.status.web.buildstatus import BuildStatusStatusResource 
-from buildbot.status.web.slaves import BuildSlavesResource
+from buildbot.status.web.slaves import BuildSlavesResource, SlavesResource
 from buildbot.status.web.status_json import JsonStatusResource
 from buildbot.status.web.xmlrpc import XMLRPCServer
 from buildbot.status.web.about import AboutBuildbot
@@ -76 +76 @@
                                 timer, and controls to accelerate the timer.
      /buildslaves : list all BuildSlaves
      /buildslaves/SLAVENAME : describe a single BuildSlave
+     /slaves : describe which slaves are connected
      /one_line_per_build : summarize the last few builds, one line each
      /one_line_per_build/BUILDERNAME : same, but only for a single builder
      /about : describe this buildmaster (Buildbot and support library versions)
@@ -303 +304 @@
         self.putChild("one_box_per_builder", Redirect("/builders"))
         self.putChild("changes", ChangesResource())
         self.putChild("buildslaves", BuildSlavesResource())
+        self.putChild("slaves", SlavesResource())
         self.putChild("buildstatus", BuildStatusStatusResource())
         #self.putChild("schedulers", SchedulersResource())
         self.putChild("one_line_per_build",

buildbot/status/web/slaves.py

@@ -125 +125 @@
             return OneBuildSlaveResource(path)
         except KeyError:
             return NoResource("No such slave '%s'" % html.escape(path))
+
+# /slaves
+class SlavesResource(HtmlResource):
+    title = "Slaves"
+    addSlash = True
+
+    def content(self, request, ctx):
+        s = self.getStatus(request)
+        slaves = ctx['slaves'] = []
+        for name in util.naturalSort(s.getSlaveNames()):
+            info = {}
+            slaves.append(info)
+            slave = s.getSlave(name)
+            slave_status = s.botmaster.slaves[name].slave_status
+            info['link'] = request.childLink(urllib.quote(name,''))
+            info['name'] = name
+            info['version'] = slave.getVersion()
+            info['connected'] = slave.isConnected()
+            
+            if slave.isConnected():
+                info['admin'] = unicode(slave.getAdmin() or '', 'utf-8')
+                last = slave.lastMessageReceived()
+                if last:
+                    info['last_heard_from_age'] = abbreviate_age(time.time() - last)
+                    info['last_heard_from_time'] = time.strftime("%Y-%b-%d %H:%M:%S",
+                                                                time.localtime(last))
+
+        template = request.site.buildbot_service.templates.get_template("slaves.html")
+        data = template.render(**ctx)
+        return data
+
+    def getChild(self, path, req):
+        try:
+            self.getStatus(req).getSlave(path)
+            return OneBuildSlaveResource(path)
+        except KeyError:
+            return NoResource("No such slave '%s'" % html.escape(path))

buildbot/status/web/templates/root.html

@@ -39 +39 @@
   per line.</li>
 
   <li class="{{ item_class.next() }}"><a href="buildslaves">Buildslave</a> information</li>
+  <li class="{{ item_class.next() }}"><a href="slaves">Slave</a> information</li>
   <li class="{{ item_class.next() }}"><a href="changes">Changesource</a> information.</li>
 
   <li class="{{ item_class.next() }}"><a href="about">About</a> this Buildbot</li>

new file uildbot/status/web/templates/slaves.html

@@ +1 @@
+{% extends "layout.html" %}
+
+{% block content %}
+
+<h1>Buildslaves</h1>
+
+<div class="column">
+
+<table class="info">
+
+<tr>
+  <th>Name</th>
+  <th>BuildBot</th>
+  <th>Admin</th>
+  <th>Last heard from</th>
+  <th>Status</th>
+</tr>
+
+{% for s in slaves %}
+  <tr class="{{ loop.cycle('alt','') }}">
+  <td><b><a href="{{ s.link }}">{{ s.name }}</a></b></td>
+  
+  <td>{{ s.version or '-' }}</td>
+ 
+  {% if s.connected %}
+    <td>
+    {%- if s.admin -%}
+      Admin: {{ s.admin|email }}
+    {%- endif -%}
+    </td>
+    
+    <td>
+    {%- if s.last_heard_from_age -%}
+      {{ s.last_heard_from_age }} <small>({{ s.last_heard_from_time }})</small>
+    {%- endif -%}
+    </td>
+        
+    {% if s.running_builds %}
+      <td class="building">Running {{ s.running_builds }} build(s)</td>
+    {% else %}
+      <td class="idle">Idle</td>
+    {% endif %}
+        
+  {% else %}
+    <td>-</td>
+    <td>-</td>
+    <td class="offline">Not connected</td>
+  {% endif %}
+  
+  </tr>
+{% endfor %}
+</table>
+
+</div>
+  
+{% endblock %}