Ticket #27: p4changes.darcs

New patches:

[p4changes
Scott Lamb <slamb@slamb.org>**20070224021946
 
 Use a more optimal form of "p4 changes", as suggested by Stewart Lord of
 Perforce technical support. From the p4d release notes:
 
   Special handling for @changelist - #85130 **
 
     The syntax '//path/file@change1,@somethingelse' now performs
     better in many common cases.  Previously, the server would
     search based on changelist number or file path according to
     hard-coded rules.  This worked poorly in a few common cases:
     both '//singlefile@1,@date' and '//...@5000,5001' started
     with the wrong search.  This left users trying odd syntax
     to second guess the server.  Now the server adaptively tries
     searching by change number, but if that appears to be too
     inefficient (more than 80% of the revisions not matching the
     path), it switches to searching by path.  (Bug #18689).
 
 In 2wire's case, this was the top source of server load, scanning
 ~2,200,000 rows for one project and ~2,700,000 rows for another every
 10 minutes. Now each scans 10-20 rows on average.
 (Figures gathered with -Ztrack=1.)
] {
hunk ./buildbot/changes/p4poller.py 31
-                     "p4bin", "pollinterval", "histmax"]
+                     "p4bin", "pollinterval"]
hunk ./buildbot/changes/p4poller.py 48
-                 pollinterval=60 * 10, histmax=100):
+                 pollinterval=60 * 10, histmax=None):
hunk ./buildbot/changes/p4poller.py 66
-        @param histmax:      maximum number of changes to look back through
+        @param histmax:      (obsolete) maximum number of changes to look back through.
+                             ignored; accepted for backwards compatibility.
hunk ./buildbot/changes/p4poller.py 77
-        self.histmax = histmax
hunk ./buildbot/changes/p4poller.py 124
-        args.extend(['changes', '-m', str(self.histmax), self.p4base + '...'])
+        args.extend(['changes'])
+        if self.last_change is not None:
+            args.extend(['%s...@%d,now' % (self.p4base, self.last_change+1)])
+        else:
+            args.extend(['-m', '1', '%s...' % (self.p4base,)])
hunk ./buildbot/changes/p4poller.py 140
-            num = m.group('num')
+            num = int(m.group('num'))
hunk ./buildbot/changes/p4poller.py 142
-                log.msg('P4Poller: starting at change %s' % num)
+                log.msg('P4Poller: starting at change %d' % num)
hunk ./buildbot/changes/p4poller.py 145
-            if last_change == num:
-                break
hunk ./buildbot/changes/p4poller.py 163
-        args.extend(['describe', '-s', num])
+        args.extend(['describe', '-s', str(num)])
hunk ./buildbot/test/test_p4poller.py 41
-    '3': change_3_log +
+    3: change_3_log +
hunk ./buildbot/test/test_p4poller.py 48
-    '2': change_2_log +
+    2: change_2_log +
hunk ./buildbot/test/test_p4poller.py 54
-    '5': change_4_log +
+    5: change_4_log +
hunk ./buildbot/test/test_p4poller.py 111
-        self.assertEquals(self.t.last_change, '1')
+        self.assertEquals(self.t.last_change, 1)
hunk ./buildbot/test/test_p4poller.py 118
-        self.assertEquals(self.t.last_change, '3')
+        self.assertEquals(self.t.last_change, 3)
hunk ./buildbot/test/test_p4poller.py 173
-        c['3'] = 'Perforce client error:\n...'
+        c[3] = 'Perforce client error:\n...'
hunk ./buildbot/test/test_p4poller.py 189
-        self.assertEquals(self.t.last_change, '2')
+        self.assertEquals(self.t.last_change, 2)
hunk ./buildbot/test/test_p4poller.py 216
-        self.assertEquals(self.t.last_change, '5')
+        self.assertEquals(self.t.last_change, 5)
}

Context:

[add Mark Pauley's launchd .plist files
warner@lothar.com**20070207081942] 
[docs: fix Requirements section to stop claiming python-2.2 compatibility. Closes #13.
warner@lothar.com**20070207061242] 
[hush most pyflakes warnings
warner@lothar.com**20070207042433] 
[html.py: oops, close the FORM tag
warner@lothar.com**20070207034138] 
[master.py: warn about orphan Builders: those which have no Schedulers to drive them
warner@lothar.com**20070207033848] 
[BotPerspective.__repr__: correct bitrot
warner@lothar.com**20070207033312] 
[update bb_applet.py, adding prefs and connect/disconnect controls
warner@allmydata.com**20070207023115] 
[update ChangeLog with 'buildbot try --diff' ticket number
warner@lothar.com**20070206230342] 
[document 'buildbot try --diff'
warner@lothar.com**20070206203428] 
[merge in 'buildbot try --diff' branch
warner@lothar.com**20070206194922] 
[steps.source: when our SourceStamp has a patch, add the contents of the patch as a LogFile
warner@allmydata.com**20070206193402] 
[implement 'try --diff', might not work yet, still needs docs and tests
warner@allmydata.com**20070206190608] 
[test_steps.py: remove the last use of reactor.iterate() in the whole tree
warner@lothar.com**20070206082226] 
[MailNotifier: assert that 'mode' is one of the supported values
warner@lothar.com**20070205184231] 
[BonsaiPoller: handle non-ascii characters. Patch from Ben Hearsum, closes SF#1632641
warner@lothar.com**20070131004315] 
[produce both .tar.gz and .zip source bundles. Closes SF#1222216
warner@lothar.com**20070127211330] 
[hush some pyflakes warnings
warner@lothar.com**20070123210346] 
[clean up maildir usage, remove a use of reactor.iterate from tests
warner@lothar.com**20070123210210] 
[bump command_version to indicate bzr support
warner@lothar.com**20070123192331] 
[buildbot/process/builder.py: don't use 'with', since it will be a reserved word in python2.6
warner@lothar.com**20070123075727] 
[bb_applet.py: add dots, swap columns left-right
warner@lothar.com**20070123072857] 
[add a gnome-panel status applet
warner@lothar.com**20070123071812] 
[merge in Bazaar (bzr) support. There are still a few unresolved issues.
warner@lothar.com**20070123054739] 
[add support for bzr (bazaar-ng)
warner@lothar.com**20070111005702] 
[darcs_buildbot.py: tidy up the progress messages
warner@lothar.com**20070120101808] 
[darcs_buildbot.py: enhance to handle multiple patches in a single push. Fixes SF#1534049
warner@lothar.com**20070117235903] 
[mark buildbot.changes.freshcvsmail as deprecated
warner@lothar.com**20061212034328] 
[remove old process/maxq.py, it now lives in buildbot.steps.maxq
warner@lothar.com**20061212033036] 
[remove more unused imports
warner@lothar.com**20061212032905] 
[remove unfinished TrialReporter
warner@lothar.com**20061212032235] 
[remove some unused imports
warner@lothar.com**20061212031101] 
[remove deprecated backwards-compatibility buildbot.process.step aliases
warner@lothar.com**20061211090833] 
[remove the now-empty twcompat.py
warner@lothar.com**20061211090345] 
[remove which(), twisted-2.0.0 and later has it
warner@lothar.com**20061211090204] 
[remove the monkeypatched t.i.utils.getProcessOutputAndValue, unnecessary with twisted-2.0.0 and later
warner@lothar.com**20061211085919] 
[remove the monkeypatched defer.waitForDeferred, unnecessary with twisted-2.0.0 and later
warner@lothar.com**20061211085809] 
[get implements() from zope.interface directly, not from twcompat
warner@lothar.com**20061211085340] 
[status.mail doesn't need to fall back to twisted.protocols.smtp.sendmail in a Twisted>=2.0.0 world
warner@lothar.com**20061211084711] 
[get Interface from zope.interface directly, not from twcompat
warner@lothar.com**20061211083750] 
[more post-Twisted-1.3.0 cleanup: remove twcompat.providedBy, use zope.interface native methods instead
warner@lothar.com**20061211083442] 
[remove all uses of buildbot.twcompat.maybeWait, now that we don't need to maintain Twisted-1.3.0 compatibility
warner@lothar.com**20061211082151] 
[bump version to 0.7.5+ while between releases
warner@lothar.com**20061211081015] 
[TAG buildbot-0.7.5
warner@lothar.com**20061211054327] 
Patch bundle hash:
0a811c2b7faffc3403cfd3c3aa9fc254fbd57581